feat(redact): add excludePaths to exempt fields from pattern scanning#93
Merged
Conversation
Lets callers whitelist fields (e.g. vendor reference ids) whose values coincidentally match aggressive value patterns like phone numbers.
size-limit report 📦
|
CI runs `npm install` against a gitignored lockfile, so it resolved the newest matching sonarjs and surfaced rules absent from the pinned 4.0.3. Pin the plugin to exact 4.2.0 and resolve the new recommended rules: - disable sonarjs/no-redundant-optional — it is purely syntactic and conflicts with exactOptionalPropertyTypes, where `?: T | undefined` is not redundant (dropping it breaks tsc across transports/builder) - rename stale slow-regex disable comments to super-linear-regex - parameterize duplicate test blocks, replace generic assertions with toBeInstanceOf/toHaveLength, add assertions to next()/done() tests, and drop a duplicate test title
Resolve conflict in plugin.comprehensive.test.ts by keeping the branch's assertion-bearing version of the async onInit test (main had the trivial `const rejected = false` form that fails sonarjs/no-trivial-assertions). Also apply toHaveLength to a generic length assertion in the newly merged basic-search-engine test so the tree satisfies sonarjs 4.2.0.
|
🎉 This issue has been resolved in version 1.12.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets callers whitelist fields (e.g. vendor reference ids) whose values coincidentally match aggressive value patterns like phone numbers.
Pull Request
📋 Description
What does this PR do?
Why is this change needed?
Related Issues
🔄 Type of Change
🧪 Testing
Test Coverage
Test Details
Manual Testing
📖 Documentation
🔍 Code Quality
📦 Dependencies
🚀 Performance
🔒 Security
📱 Compatibility
🎃 Hacktoberfest
📸 Screenshots/Examples
Before
After
Code Example
🔗 Additional Context
Deployment Notes
Rollback Plan
Future Considerations
✅ Reviewer Checklist
📝 Notes for Reviewers
🙏 Acknowledgments
Thank you for contributing to Logixia! 🚀